Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

style: use builtin 'command -v' instead of nonstandard 'which' #1185

Merged
merged 1 commit into from May 1, 2019

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented May 1, 2019

Reason for Change:
Enforces the use of POSIX shell builtin command -v instead of the nonstandard which command.

See https://github.com/koalaman/shellcheck/wiki/SC2230

Issue Fixed:

Refs #953

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #1185 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1185   +/-   ##
=======================================
  Coverage   74.66%   74.66%           
=======================================
  Files         128      128           
  Lines       18210    18210           
=======================================
  Hits        13597    13597           
  Misses       3829     3829           
  Partials      784      784

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented May 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit 0d313b8 into Azure:master May 1, 2019
@mboersma mboersma deleted the shellcheck-2230 branch May 1, 2019 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants