fix: enableEncryptionWithExternalKms with master VMSS missing objectID #1194
Conversation
/hold for manual validation |
@davidmatson FYI |
So this fixes the case when useManagedIdentity is false? |
Correct |
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
=========================================
- Coverage 74.7% 74.7% -0.01%
=========================================
Files 128 128
Lines 18235 18234 -1
=========================================
- Hits 13622 13621 -1
Misses 3829 3829
Partials 784 784 |
lgtm |
/hold cancel validated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Restore
CreateKeyVaultVMSS
to the behavior it had before the template refactor forenableEncryptionWithExternalKms
. Compare with:https://github.com/Azure/aks-engine/blob/release-v0.31.0/parts/k8s/kubernetesmasterresourcesvmss.t#L76
Issue Fixed:
Fixes #1034
Requirements:
Notes: