Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: enableEncryptionWithExternalKms with master VMSS missing objectID #1194

Merged
merged 2 commits into from May 1, 2019

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented May 1, 2019

Reason for Change:

Restore CreateKeyVaultVMSS to the behavior it had before the template refactor for enableEncryptionWithExternalKms. Compare with:
https://github.com/Azure/aks-engine/blob/release-v0.31.0/parts/k8s/kubernetesmasterresourcesvmss.t#L76

Issue Fixed:

Fixes #1034

Requirements:

Notes:

@acs-bot acs-bot added the size/XS label May 1, 2019
@CecileRobertMichon
Copy link
Contributor Author

/hold

for manual validation

@CecileRobertMichon
Copy link
Contributor Author

@davidmatson FYI

@jackfrancis
Copy link
Member

So this fixes the case when useManagedIdentity is false?

@CecileRobertMichon
Copy link
Contributor Author

So this fixes the case when useManagedIdentity is false?

Correct

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #1194 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1194      +/-   ##
=========================================
- Coverage    74.7%   74.7%   -0.01%     
=========================================
  Files         128     128              
  Lines       18235   18234       -1     
=========================================
- Hits        13622   13621       -1     
  Misses       3829    3829              
  Partials      784     784

@jackfrancis
Copy link
Member

lgtm

@CecileRobertMichon
Copy link
Contributor Author

/hold cancel

validated

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit c933842 into master May 1, 2019
@CecileRobertMichon CecileRobertMichon deleted the CecileRobertMichon/fix-objectid branch May 1, 2019 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enableEncryptionWithExternalKms broken due to missing objectId in generated template
4 participants