Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

style: sudo doesn't affect redirects #1213

Merged
merged 3 commits into from May 4, 2019
Merged

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented May 2, 2019

Reason for Change:
Points out in shell scripts when a sudo command is redirected, since that's likely to be a bug.

See https://github.com/koalaman/shellcheck/wiki/SC2024

Issue Fixed:
Refs #953

Requirements:

Notes:

@acs-bot acs-bot added the size/XS label May 2, 2019
@mboersma mboersma changed the title refactor: sudo doesn't affect redirects style: sudo doesn't affect redirects May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #1213 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1213      +/-   ##
=========================================
+ Coverage    74.7%   74.7%   +<.01%     
=========================================
  Files         128     128              
  Lines       18234   18236       +2     
=========================================
+ Hits        13621   13623       +2     
  Misses       3829    3829              
  Partials      784     784

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit 5536ad2 into Azure:master May 4, 2019
@mboersma mboersma deleted the shellcheck-2024 branch May 6, 2019 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants