This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboersma
changed the title
refactor: sudo doesn't affect redirects
style: sudo doesn't affect redirects
May 2, 2019
mboersma
commented
May 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
=========================================
+ Coverage 74.7% 74.7% +<.01%
=========================================
Files 128 128
Lines 18234 18236 +2
=========================================
+ Hits 13621 13623 +2
Misses 3829 3829
Partials 784 784 |
CecileRobertMichon
approved these changes
May 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jackfrancis
approved these changes
May 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Points out in shell scripts when a
sudo
command is redirected, since that's likely to be a bug.See https://github.com/koalaman/shellcheck/wiki/SC2024
Issue Fixed:
Refs #953
Requirements:
Notes: