Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: removing PodSecurityPolicy files from manifests folders #1257

Merged
merged 2 commits into from May 9, 2019
Merged

fix: removing PodSecurityPolicy files from manifests folders #1257

merged 2 commits into from May 9, 2019

Conversation

allantargino
Copy link
Member

@allantargino allantargino commented May 8, 2019

Reason for Change:

Issue #633 describes a bug with kubelet trying to parse PodSecurityPolicy (PSP) file into a pod. The reason is because the PSP file were in a folder used by the kubelet to setup static pod definitions, causing the kubelet to try deploying it every 20s (default value for polling the definitions folder).
The current cloudinit placeholder used to inject the PSP file is MASTER_MANIFESTS_CONFIG_PLACEHOLDER. There are 2 other places in the current templates we can inject it:

  • MASTER_ADDONS_CONFIG_PLACEHOLDER
  • MASTER_CONTAINER_ADDONS_PLACEHOLDER
    Since addons seems more generic than container addons placeholder, I opted to move it to this location.

Issue Fixed:

fixes #633

Requirements:

Notes:

@welcome
Copy link

welcome bot commented May 8, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@acs-bot acs-bot added the size/S label May 8, 2019
@allantargino allantargino changed the title Removing PodSecurityPolicy files from manifests folders fix: removing PodSecurityPolicy files from manifests folders May 8, 2019
@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #1257 into master will increase coverage by 0.18%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1257      +/-   ##
=========================================
+ Coverage   74.81%     75%   +0.18%     
=========================================
  Files         128     129       +1     
  Lines       18318   18537     +219     
=========================================
+ Hits        13705   13904     +199     
- Misses       3829    3840      +11     
- Partials      784     793       +9

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis
Copy link
Member

Thanks for this @allantargino!

@acs-bot acs-bot added size/M and removed size/S labels May 9, 2019
@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented May 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: allantargino, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit 53d1a6c into Azure:master May 9, 2019
@welcome
Copy link

welcome bot commented May 9, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@allantargino allantargino deleted the fix-psp-manifest-folder branch May 25, 2019 14:49
@allantargino allantargino self-assigned this May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pod-security-policy.yaml is being parsed as a pod
4 participants