Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: aks-engine deploy tutorial errors out for auth method as CLI for linux container on windows #1263

Merged

Conversation

munishm
Copy link
Contributor

@munishm munishm commented May 8, 2019

If you try to run as per the documentation inside the container, it errors out because of auth-method as CLI when running it inside the linux container on windows.

Two probable solutions:
Either don't set the authentication method here
Or set the auth-method to client-secret

Reason for Change:
Fixes the tutorial documentation for the case if running it inside the linux container on windows

Issue Fixed:

#1108 & #773 partially

Requirements:

Notes:

If you try to run as per the documentation inside the container, it errors out becuase of auth-method as CLI. If you remove this, it works perfectly or change the auth-method to client secret.
@welcome
Copy link

welcome bot commented May 8, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks @munishm !

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label May 8, 2019
@jackfrancis jackfrancis merged commit 29ecab4 into Azure:master May 8, 2019
@welcome
Copy link

welcome bot commented May 8, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@acs-bot
Copy link

acs-bot commented May 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, munishm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants