This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
build: validate deps before 'make build', and some cleanup #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1271 +/- ##
=======================================
Coverage 74.84% 74.84%
=======================================
Files 128 128
Lines 18338 18338
=======================================
Hits 13725 13725
Misses 3829 3829
Partials 784 784 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Cleans up the
Makefilein some minor ways:validate-dependenciesa prerequisite target formake buildvalidate-goandvalidate-shelltargets for convenience and consistencyvalidate-copyright-headerstomake test-stylevalidate-commit-msg.shscript that we punted onThe first bullet point in particular I think is important. I was bitten by this recently: my branch passed
make clean build test-style testlocally but failed in CI becausedep checkhadn't been run.It's also worth noting that the
validate-dependenciesandvalidate-copyright-headerstargets that this adds to the common developer workflow take negligible time.Issue Fixed:
Requirements:
Notes:
Apologies for mixing concerns in one PR. I didn't think these changes were particularly controversial but I'm happy to separate them if that's preferable.