Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: update group name and corresponding output folder names #1280

Conversation

munishm
Copy link
Contributor

@munishm munishm commented May 10, 2019

Reason for Change:
More accurate with the names even though hard coded. Would be easy to understand the example and relate.

Issue Fixed:
#1258

Requirements:

Notes:

A user can run it as it is to make it work.
@acs-bot acs-bot added the size/S label May 10, 2019
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does make it more consistent IMHO, just had a question about the dnsPrefix paragraph addition.

docs/topics/windows.md Outdated Show resolved Hide resolved
@mboersma
Copy link
Member

@PatrickLang could you take a look at this Windows doc change?

Co-Authored-By: Cecile Robert-Michon <cerobert@microsoft.com>
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #1280 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
+ Coverage   74.76%   74.89%   +0.13%     
==========================================
  Files         128      128              
  Lines       18333    18379      +46     
==========================================
+ Hits        13706    13765      +59     
+ Misses       3836     3820      -16     
- Partials      791      794       +3

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patrick is out traveling this week so making the call to merge this one.

/lgtm

@acs-bot
Copy link

acs-bot commented May 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, munishm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit 0263686 into Azure:master May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants