Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Coredns deployment tolerates all NoSchedule taints. #1325

Closed
fampton opened this issue May 17, 2019 · 5 comments
Closed

Coredns deployment tolerates all NoSchedule taints. #1325

fampton opened this issue May 17, 2019 · 5 comments

Comments

@fampton
Copy link

fampton commented May 17, 2019

effect: NoSchedule

For unique hardware we will typically apply a noschedule taint to avoid unnecessary pods getting scheduled onto them. The coredns pod seems to have tolerations for any noschedule taint, which prevents the node from being scaled down by the cluster autoscaler if coredns is scheduled onto it.

@welcome
Copy link

welcome bot commented May 17, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.

@mboersma
Copy link
Member

This was added in #555. The idea was to ensure core system components could always be scheduled.

@jackfrancis could we revisit the NoSchedule taint toleration?

@jackfrancis
Copy link
Member

I think we want to enable this as an option. @palma21 drove this effort in response to user feedback that folks wanted this prioritized scheduling toleration for coredns and other system components,

@palma21
Copy link
Member

palma21 commented May 21, 2019

That sounds like incorrect behavior from the scaling side. Do you have some kind of pod disruption budget? The node should be able to scale down if k8s sees that it can schedule it somewhere else and resources are underutilized.

That said, if you don't want the coredns pods on your specific hardware machines, do remove the toleration on your deployment. We have a number of use cases that will break if we remove it for everyone, but we can certainly revisit.

@fampton
Copy link
Author

fampton commented Jun 14, 2019

Thanks for confirming this is expected. Modifying the CoreDNS deployment will work.

@fampton fampton closed this as completed Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants