This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: never use 3.0.4 for moby-cli and update moby on upgrade #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CecileRobertMichon
changed the title
jackfrancis
reviewed
May 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #1359 +/- ##
=======================================
Coverage 75.45% 75.45%
=======================================
Files 128 128
Lines 18124 18124
=======================================
Hits 13675 13675
Misses 3651 3651
Partials 798 798 |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Backwards compatibility is broken in master because the moby install function is trying to install moby-cli 3.0.4 for clusters that were deployed with previous versions of aks-engine that had mobyVersion
3.0.4.Issue Fixed:
#1355
Requirements:
Notes: