Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: disable redundant cosmosdb regions #1403

Merged
merged 1 commit into from
May 29, 2019

Conversation

jackfrancis
Copy link
Member

Reason for Change:

multiple cosmosdb regions for a single customer is not currently supported by cosmosdb

See:

https://azure.microsoft.com/en-us/resources/videos/azure-cosmosdb-global-distribution/

Issue Fixed:

Fixes #1400

Requirements:

Notes:

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1403 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1403      +/-   ##
=========================================
- Coverage    75.5%   75.5%   -0.01%     
=========================================
  Files         128     128              
  Lines       18144   18141       -3     
=========================================
- Hits        13700   13697       -3     
  Misses       3641    3641              
  Partials      803     803

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@CecileRobertMichon
Copy link
Contributor

is there a cosmos etcd E2E we can run to validate?

@acs-bot
Copy link

acs-bot commented May 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit da5fe5e into Azure:master May 29, 2019
@jackfrancis jackfrancis deleted the cosmos-regions-fix branch May 29, 2019 23:53
CecileRobertMichon pushed a commit to CecileRobertMichon/aks-engine that referenced this pull request May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes cluster creation fails with CosmosEtcd
4 participants