Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: add k8s 1.14.1 for Azure Stack to VHD script #1483

Merged
merged 1 commit into from Jun 14, 2019

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jun 14, 2019

Reason for Change:
Adds hyperkube support for Kubernetes 1.14.1 on Azure Stack to the VHD image script.

Issue Fixed:
This was prompted by the docs changes in #1482.

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #1483 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1483   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files         128      128           
  Lines       18136    18136           
=======================================
  Hits        13709    13709           
  Misses       3636     3636           
  Partials      791      791

@rjaini
Copy link
Contributor

rjaini commented Jun 14, 2019

/hold We found some issue on Azure Stack with v1.14.x version. We will update once we understand the issue and the resolution.

@rjaini
Copy link
Contributor

rjaini commented Jun 14, 2019

/hold cancel

@rjaini
Copy link
Contributor

rjaini commented Jun 14, 2019

The issue was false alarm.

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Jun 14, 2019
@acs-bot acs-bot merged commit d329f29 into Azure:master Jun 14, 2019
@acs-bot
Copy link

acs-bot commented Jun 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis added this to Done in backlog Jun 19, 2019
@mboersma mboersma deleted the add-1.14-azs-to-vhd branch June 21, 2019 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants