chore: Change Windows default image to Jun 2019 #1489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
=======================================
Coverage 75.77% 75.77%
=======================================
Files 128 128
Lines 18357 18357
=======================================
Hits 13910 13910
Misses 3651 3651
Partials 796 796 |
| @@ -247,11 +247,11 @@ const ( | |||
| // DefaultWindowsPublisher sets the default WindowsPublisher value in WindowsProfile | |||
| DefaultWindowsPublisher = "MicrosoftWindowsServer" | |||
| // DefaultWindowsOffer sets the default WindowsOffer value in WindowsProfile | |||
| DefaultWindowsOffer = "WindowsServerSemiAnnual" | |||
| DefaultWindowsOffer = "WindowsServer" | |||
There was a problem hiding this comment.
I don't think this should have changed. Checking with team publishing the images
There was a problem hiding this comment.
The publishing team intended to change this, so I'm updating the docs to match.
|
cc @adelina-t |
|
Will need to continue hold. This isn't the right image :( |
PatrickLang
force-pushed
the
patchtuesday-jun2019
branch
from
951df5d
to
e7124ac
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* chore: Change Windows default image to Jun 2019 * Update doc to clarify that all 4 parameters are needed for custom image testing
Reason for Change:
This updates the last-known-good image to the latest Windows patch release. There were some issues that could break DNS in April/May cumulative updates.
Issue Fixed:
Requirements:
Notes:
/hold
I was expecting this to have a date on or after the 2nd Tuesday which is June 10, not June 4. I need to make sure this is the right one before merge.