Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: swap ensure-generated and test-style tasks #1501

Merged
merged 1 commit into from Jun 20, 2019

Conversation

mboersma
Copy link
Member

Reason for Change:
The Check if generated code is up to date Azure DevOps task would always succeed because make generate had just been run in the previous Run linting rules task. This swaps them as a simple workaround.

Seems to work, as proved by #1406. 馃槄

Issue Fixed:
Fixes #1318

Requirements:

Notes:

@jackfrancis
Copy link
Member

doh

@jackfrancis
Copy link
Member

/lgtm

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

good one

@acs-bot
Copy link

acs-bot commented Jun 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #1501 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1501   +/-   ##
=======================================
  Coverage   75.77%   75.77%           
=======================================
  Files         128      128           
  Lines       18357    18357           
=======================================
  Hits        13910    13910           
  Misses       3651     3651           
  Partials      796      796

@mboersma
Copy link
Member Author

I wanted to do a more robust fix, like git stash / git stash pop before and after the command, but in CI that just fails with Please configure a git user.name and user.email and I wasn't going to deal with that.

@jackfrancis jackfrancis added this to In progress in backlog Jun 19, 2019
@acs-bot acs-bot merged commit 9181a7d into Azure:master Jun 20, 2019
backlog automation moved this from In progress to Done Jun 20, 2019
@mboersma mboersma deleted the ensure-generated-workaround branch June 20, 2019 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

generated code files are falling out of sync
4 participants