Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: Set encoding:gzip on cilium BPFFS mount unit #1514

Merged
merged 1 commit into from Jun 21, 2019
Merged

fix: Set encoding:gzip on cilium BPFFS mount unit #1514

merged 1 commit into from Jun 21, 2019

Conversation

UnwashedMeme
Copy link
Contributor

Reason for Change:

Since the mount content that we're including here is gzipped we need
this flag to cloud-init to gunzip it as it is being put in
place. Without this the file is still gzipped and systemd ignores it.

Issue Fixed:

Fixes #1393

Requirements:

Notes:

Since the mount content that we're including here is gzipped we need
this flag to cloud-init to gunzip it as it is being put in
place. Without this the file is still gzipped and systemd ignores it.

fixes #1393
@welcome
Copy link

welcome bot commented Jun 21, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@msftclas
Copy link

msftclas commented Jun 21, 2019

CLA assistant check
All CLA requirements met.

@UnwashedMeme
Copy link
Contributor Author

This fixes a small bug that was introduced during refactoring (See #1393 for gory details) where a systemd unit file is gzipped in the cloud-init but not gunzipped when put in place.

/assign @jackfrancis

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Jun 21, 2019
@jackfrancis
Copy link
Member

And thanks for enduring all the gore @UnwashedMeme :|

@acs-bot
Copy link

acs-bot commented Jun 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, UnwashedMeme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackfrancis jackfrancis merged commit 3ce79f1 into Azure:master Jun 21, 2019
@welcome
Copy link

welcome bot commented Jun 21, 2019

Congrats on merging your first pull request! 🎉🎉🎉

jackfrancis pushed a commit that referenced this pull request Jun 21, 2019
Since the mount content that we're including here is gzipped we need
this flag to cloud-init to gunzip it as it is being put in
place. Without this the file is still gzipped and systemd ignores it.

fixes #1393
chappleg pushed a commit to chappleg/aks-engine that referenced this pull request Jul 1, 2019
Since the mount content that we're including here is gzipped we need
this flag to cloud-init to gunzip it as it is being put in
place. Without this the file is still gzipped and systemd ignores it.

fixes Azure#1393
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium BPFFS mount unit file is incorrectly gzipped
4 participants