Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: set ipam environment to mas in Azure CNI config on Azure Stack #1542

Merged
merged 4 commits into from Jul 1, 2019

Conversation

chappleg
Copy link
Contributor

Reason for Change:

See #1539

Issue Fixed:

#1539

Requirements:

Notes:

@chappleg chappleg added this to In progress in Azure Stack via automation Jun 27, 2019
@acs-bot acs-bot added the size/M label Jun 27, 2019
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #1542 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1542   +/-   ##
=======================================
  Coverage   75.85%   75.85%           
=======================================
  Files         128      128           
  Lines       18310    18310           
=======================================
  Hits        13889    13889           
  Misses       3636     3636           
  Partials      785      785

@jackfrancis
Copy link
Member

lgtm from a linux perspective

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@CecileRobertMichon CecileRobertMichon added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Jul 1, 2019
@CecileRobertMichon CecileRobertMichon removed the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Jul 1, 2019
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jul 1, 2019
@acs-bot acs-bot merged commit 7fcccb4 into Azure:master Jul 1, 2019
Azure Stack automation moved this from In progress to Done Jul 1, 2019
@acs-bot
Copy link

acs-bot commented Jul 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, rjaini, t-chappl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Azure Stack
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants