This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: set ipam environment to mas in Azure CNI config on Azure Stack #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
=======================================
Coverage 75.85% 75.85%
=======================================
Files 128 128
Lines 18310 18310
=======================================
Hits 13889 13889
Misses 3636 3636
Partials 785 785 |
lgtm from a linux perspective |
CecileRobertMichon
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
rjaini
approved these changes
Jul 1, 2019
CecileRobertMichon
added
the
needs-rebase
Changes in the target branch require a `git rebase` and `git push -f`
label
Jul 1, 2019
CecileRobertMichon
removed
the
needs-rebase
Changes in the target branch require a `git rebase` and `git push -f`
label
Jul 1, 2019
CecileRobertMichon
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, rjaini, t-chappl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
See #1539
Issue Fixed:
#1539
Requirements:
Notes: