This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: Add checks for Metadata, AcceleratedNetworking and etcdDiskSizeGB on Azure Stack to fail fast. #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honcao
approved these changes
Jul 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #1564 +/- ##
==========================================
+ Coverage 75.86% 75.87% +0.01%
==========================================
Files 128 128
Lines 18314 18325 +11
==========================================
+ Hits 13893 13905 +12
+ Misses 3636 3635 -1
Partials 785 785 |
4 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, honcao, rjaini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
On Azure Stack we dont support certain flags and expected to be in certain value or range.
This change add validation so that proper error is returned early and fail fast.
Issue Fixed:
Fixes #1563
Requirements:
Notes: