Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: changed accelerated networking example VMs #1569

Merged
merged 1 commit into from Jul 3, 2019
Merged

docs: changed accelerated networking example VMs #1569

merged 1 commit into from Jul 3, 2019

Conversation

Alwandy
Copy link
Contributor

@Alwandy Alwandy commented Jul 3, 2019

Due to Standard_D2_v3 not being supported with accelerated network due to 2 vCPUs, the example should use standard_D4_v3 instead.

Reason for Change:
Standard_D2_v3 is not supported with accelerated networking due to 2 vCPUs, changing to D4_v3 on the example makes the example valid.

Issue Fixed:
Fixes #1531

Requirements:

Notes:

Due to Standard_D2_v3 not being supported with accelerated network due to 2 vCPUs, the example should use standard_D4_v3 instead.
@welcome
Copy link

welcome bot commented Jul 3, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@acs-bot acs-bot added the size/XS label Jul 3, 2019
@Alwandy Alwandy changed the title Changed from Standard_D2_v3 to Standard_D4_v3 - fix: changed accelerated networking example VMs Jul 3, 2019
@Alwandy Alwandy changed the title fix: changed accelerated networking example VMs docs: changed accelerated networking example VMs Jul 3, 2019
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @Alwandy!

@acs-bot acs-bot added the lgtm label Jul 3, 2019
@CecileRobertMichon CecileRobertMichon merged commit ca05d2d into Azure:master Jul 3, 2019
@welcome
Copy link

welcome bot commented Jul 3, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@acs-bot
Copy link

acs-bot commented Jul 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Alwandy, CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard_D2_v3 does not support AgentPoolProfile.acceleratedNetworking
3 participants