fix: disable unattended upgrades during CSE execution #1681

sylr · 2019-07-29T12:55:18Z

Signed-off-by: Sylvain Rabot s.rabot@lectra.com

Reason for Change:

Issue Fixed:

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:

jackfrancis · 2019-07-29T19:29:28Z

/azp run pr-e2e

azure-pipelines · 2019-07-29T19:29:37Z

Azure Pipelines successfully started running 1 pipeline(s).

parts/k8s/cloud-init/artifacts/cse_install.sh

parts/k8s/cloud-init/masternodecustomdata.yml

jackfrancis · 2019-07-29T23:54:12Z

/azp run pr-e2e

azure-pipelines · 2019-07-29T23:54:21Z

Azure Pipelines successfully started running 1 pipeline(s).

codecov · 2019-07-30T00:34:22Z

Codecov Report

Merging #1681 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1681   +/-   ##
=======================================
  Coverage   72.11%   72.11%           
=======================================
  Files         142      142           
  Lines       26270    26270           
=======================================
  Hits        18945    18945           
  Misses       6230     6230           
  Partials     1095     1095

Impacted Files	Coverage Δ
pkg/engine/templates_generated.go	`31.57% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae57a4c...05dadfa. Read the comment docs.

stale · 2019-08-29T00:53:43Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sylr · 2019-10-07T15:16:24Z

@jackfrancis can we move forward with this ?

sylr · 2019-10-21T09:21:26Z

Guys ?

stale · 2019-11-20T09:24:11Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2019-12-21T16:56:26Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sylr · 2019-12-22T21:51:05Z

ping

stale · 2020-01-21T22:11:55Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

acs-bot · 2020-03-17T17:06:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sylr
To complete the pull request process, please assign mboersma
You can assign the PR to them by writing /assign @mboersma in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mboersma · 2020-03-17T17:22:19Z

/azp run pr-e2e

azure-pipelines · 2020-03-17T17:22:29Z

Azure Pipelines successfully started running 1 pipeline(s).

mboersma · 2020-04-03T16:49:58Z

/azp run pr-e2e

azure-pipelines · 2020-04-03T16:50:08Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>

mboersma · 2020-04-03T19:11:55Z

I tested this interactively by running this command as soon as the still-provisioning master was ready for ssh:

$ watch apt-config dump APT::Periodic::Unattended-Upgrade
APT::Periodic::Unattended-Upgrade "0";

At about the same time as aks-engine deploy returned, the value changed to 1.

jackfrancis · 2020-04-03T20:14:26Z

/azp run pr-e2e

azure-pipelines · 2020-04-03T20:14:35Z

Azure Pipelines successfully started running 1 pipeline(s).

jackfrancis

/lgtm

* fix: disable unattended upgrades during CSE execution Signed-off-by: Sylvain Rabot <s.rabot@lectra.com> * style: remove comments to save CSE bytes Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com>

* fix: disable unattended upgrades during CSE execution Signed-off-by: Sylvain Rabot <s.rabot@lectra.com> * style: remove comments to save CSE bytes Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Sylvain Rabot <s.rabot@lectra.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com>

jackfrancis reviewed Jul 29, 2019

View reviewed changes

parts/k8s/cloud-init/artifacts/cse_install.sh Outdated Show resolved Hide resolved

jackfrancis reviewed Jul 29, 2019

View reviewed changes

parts/k8s/cloud-init/masternodecustomdata.yml Outdated Show resolved Hide resolved

sylr force-pushed the unattended-upgrades branch from abf5372 to 5dbbce7 Compare July 29, 2019 19:44

stale bot added the stale label Aug 29, 2019

mboersma added the awaiting review label Aug 30, 2019

stale bot removed the stale label Aug 30, 2019

acs-bot added the size/M label Sep 9, 2019

sylr force-pushed the unattended-upgrades branch from 9e51fa3 to 9318daa Compare September 9, 2019 13:16

stale bot added stale and removed stale labels Nov 20, 2019

stale bot added the stale label Dec 21, 2019

stale bot removed the stale label Dec 22, 2019

stale bot added the stale label Jan 21, 2020

mboersma added the backlog label Jan 24, 2020

stale bot removed the stale label Jan 24, 2020

jackfrancis added this to Under Review in backlog Jan 29, 2020

mboersma self-assigned this Mar 4, 2020

mboersma force-pushed the unattended-upgrades branch from 43b0956 to 9c6be97 Compare March 17, 2020 17:04

mboersma force-pushed the unattended-upgrades branch from 9c6be97 to 05074a0 Compare April 3, 2020 16:49

Sylvain Rabot and others added 2 commits April 3, 2020 12:48

fix: disable unattended upgrades during CSE execution

9754c6b

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>

style: remove comments to save CSE bytes

05dadfa

mboersma force-pushed the unattended-upgrades branch from 05074a0 to 05dadfa Compare April 3, 2020 18:53

mboersma removed the awaiting review label Apr 3, 2020

jackfrancis approved these changes Apr 3, 2020

View reviewed changes

mboersma merged commit 0fff207 into Azure:master Apr 3, 2020

backlog automation moved this from Under Review to Done Apr 3, 2020

jackfrancis mentioned this pull request Apr 13, 2020

fix: retry more aggressively when install the gpu deb package. #3065

Merged

fmotrifork mentioned this pull request Apr 14, 2020

aks-engine 0.49.0 fishworks/fish-food#678

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: disable unattended upgrades during CSE execution #1681

fix: disable unattended upgrades during CSE execution #1681

sylr commented Jul 29, 2019

jackfrancis commented Jul 29, 2019

azure-pipelines bot commented Jul 29, 2019

jackfrancis commented Jul 29, 2019

azure-pipelines bot commented Jul 29, 2019

codecov bot commented Jul 30, 2019 •

edited

stale bot commented Aug 29, 2019

sylr commented Oct 7, 2019

sylr commented Oct 21, 2019

stale bot commented Nov 20, 2019

stale bot commented Dec 21, 2019

sylr commented Dec 22, 2019

stale bot commented Jan 21, 2020

acs-bot commented Mar 17, 2020

mboersma commented Mar 17, 2020

azure-pipelines bot commented Mar 17, 2020

mboersma commented Apr 3, 2020

azure-pipelines bot commented Apr 3, 2020

mboersma commented Apr 3, 2020

jackfrancis commented Apr 3, 2020

azure-pipelines bot commented Apr 3, 2020

jackfrancis left a comment

fix: disable unattended upgrades during CSE execution #1681

fix: disable unattended upgrades during CSE execution #1681

Conversation

sylr commented Jul 29, 2019

jackfrancis commented Jul 29, 2019

azure-pipelines bot commented Jul 29, 2019

jackfrancis commented Jul 29, 2019

azure-pipelines bot commented Jul 29, 2019

codecov bot commented Jul 30, 2019 • edited

Codecov Report

stale bot commented Aug 29, 2019

sylr commented Oct 7, 2019

sylr commented Oct 21, 2019

stale bot commented Nov 20, 2019

stale bot commented Dec 21, 2019

sylr commented Dec 22, 2019

stale bot commented Jan 21, 2020

acs-bot commented Mar 17, 2020

mboersma commented Mar 17, 2020

azure-pipelines bot commented Mar 17, 2020

mboersma commented Apr 3, 2020

azure-pipelines bot commented Apr 3, 2020

mboersma commented Apr 3, 2020

jackfrancis commented Apr 3, 2020

azure-pipelines bot commented Apr 3, 2020

jackfrancis left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 30, 2019 •

edited