Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: retry’able node get #1987

Merged
merged 1 commit into from Sep 19, 2019

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Our most common E2E flake at present is node get operations returning unexpected results. This PR tolerates transient node get responses within a given retry timeout period.

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/L label Sep 19, 2019
@acs-bot
Copy link

acs-bot commented Sep 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #1987 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1987      +/-   ##
==========================================
- Coverage   76.71%   76.71%   -0.01%     
==========================================
  Files         135      135              
  Lines       20573    20557      -16     
==========================================
- Hits        15783    15770      -13     
+ Misses       3873     3871       -2     
+ Partials      917      916       -1

@jackfrancis jackfrancis merged commit 869cc8a into Azure:master Sep 19, 2019
@jackfrancis jackfrancis deleted the e2e-nodes-get-async branch September 19, 2019 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants