Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: continue upgrading after node drain error #2013

Merged
merged 1 commit into from Sep 23, 2019

Conversation

mboersma
Copy link
Member

Reason for Change:
Doesn't return an error that occurs while draining a node during upgrade, just log it.

The idea here is that "cordon and drain" is the polite, best-effort way to upgrade, but that if it fails, upgrade can still delete the node and things will succeed with a bit more disruption to workloads.

Issue Fixed:
Fixes #1919

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #2013 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
+ Coverage   76.72%   76.73%   +<.01%     
==========================================
  Files         135      135              
  Lines       20574    20573       -1     
==========================================
  Hits        15786    15786              
+ Misses       3872     3871       -1     
  Partials      916      916

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Sep 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit 10ce59c into Azure:master Sep 23, 2019
@mboersma mboersma deleted the just-log-vmss-drain-errors branch September 23, 2019 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade VMSS node may fail with drain error
3 participants