This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: fix cni conf json for single exception address #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2157 +/- ##
=======================================
Coverage 76.55% 76.55%
=======================================
Files 135 135
Lines 20709 20709
=======================================
Hits 15854 15854
Misses 3931 3931
Partials 924 924 |
|
sometimes a bug just needs some coercion to go away /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, marosset, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CecileRobertMichon
pushed a commit
that referenced
this pull request
Oct 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fixes an issue where invalid cni conf json is generated when route exception lists contain a single value by forcing powershell function to return an array even for single values in GetBroadestRangesForEachAddress function
Issue Fixed:
This should fix failing windows/custom_vnet jenkins test jobs
Requirements:
Notes: