Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: addons "update config" is upgrade-only #2282

Merged
merged 2 commits into from
Nov 8, 2019

Conversation

jackfrancis
Copy link
Member

Reason for Change:

We are unnecessarily re-configuring the api model addons spec on both scale and upgrade operations. We should only be doing this for upgrade operations, as scale operations do not affect the master vms, and thus do not change the control plane implementation.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #2282 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2282   +/-   ##
=======================================
  Coverage   71.27%   71.27%           
=======================================
  Files         142      142           
  Lines       24471    24471           
=======================================
  Hits        17441    17441           
  Misses       5916     5916           
  Partials     1114     1114

@CecileRobertMichon
Copy link
Contributor

do we also need to update the unit tests https://github.com/Azure/acs-engine/pull/4224/files#diff-daf624fb49e7cf74e670db52d41e949a ?

can you run a backcompat scale test on this (with a release before PR 4224 merged) just to make sure we're not missing anything?

@jackfrancis
Copy link
Member Author

@CecileRobertMichon in fact the proof that this is the right thing is in not changing the UT and validating everything is still green.

@acs-bot acs-bot added size/M and removed size/XS labels Nov 7, 2019
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acs-bot
Copy link

acs-bot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 56aa9be into Azure:master Nov 8, 2019
@jackfrancis jackfrancis deleted the addons-isUpgrade branch November 8, 2019 04:21
@jackfrancis jackfrancis added this to the v0.44.0 milestone Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants