This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: bumping timeout for getting management ip on windows nodes #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pradipd |
|
Related to #2281 |
Codecov Report
@@ Coverage Diff @@
## master #2284 +/- ##
=======================================
Coverage 71.64% 71.64%
=======================================
Files 142 142
Lines 24519 24519
=======================================
Hits 17566 17566
Misses 5828 5828
Partials 1125 1125 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
marosset
changed the title
marosset
changed the title
|
PR title has been updated, thanks @CecileRobertMichon |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Some customers are seeing issues where the windows nodes do not come up because a management IP address never resolved. This PR extends the timeout (per guidance from networking team)
Issue Fixed:
#2281
Requirements:
Notes: