This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
refactor: use go template for kubelet systemd config #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2320 +/- ##
=========================================
Coverage ? 71.73%
=========================================
Files ? 142
Lines ? 24993
Branches ? 0
=========================================
Hits ? 17928
Misses ? 5934
Partials ? 1131 |
jackfrancis
changed the title
mboersma
approved these changes
Nov 19, 2019
| KUBELET_REGISTER_NODE=--register-node=true | ||
| KUBELET_REGISTER_WITH_TAINTS=--register-with-taints=node-role.kubernetes.io/master=true:NoSchedule | ||
| {{end}} | ||
| {{else}} | ||
| KUBELET_REGISTER_SCHEDULABLE={{WrapAsVariable "registerSchedulable"}} |
There was a problem hiding this comment.
Was this cruft? I don't see it referenced anywhere else.
| @@ -367,13 +362,9 @@ MASTER_CONTAINER_ADDONS_PLACEHOLDER | |||
| {{if IsAzureStackCloud }} | |||
| AZURE_ENVIRONMENT_FILEPATH=/etc/kubernetes/azurestackcloud.json | |||
| {{end}} | |||
| {{if IsKubernetesVersionGe "1.6.0"}} | |||
There was a problem hiding this comment.
K8s 1.6.0 was like a hundred years ago.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Move kubelet systemd configuration to go templating to be more maintainable, flexible, and agile.
Issue Fixed:
Requirements:
Notes: