This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
refactor: optimize CSE main script for go template #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2339 +/- ##
=========================================
+ Coverage 71.85% 71.9% +0.05%
=========================================
Files 130 130
Lines 23365 23392 +27
=========================================
+ Hits 16788 16820 +32
+ Misses 5550 5546 -4
+ Partials 1027 1026 -1 |
jackfrancis
force-pushed
the
cse_main_go_template
branch
from
8dbca4b
to
a6c4745
Compare
|
/azp run pr-e2e |
2 similar comments
|
/azp run pr-e2e |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run pr-e2e |
jackfrancis
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
mboersma
reviewed
Nov 21, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
ifblocks (including a few stragglers incse_config.shAZURE_POLICY_ADDONbash var via ARM (we can get this value via the ContainerService context of the go template layer directly at template generation time)TARGET_ENVIRONMENTPRIVATE_AZURE_REGISTRY_SERVERensureDHCPv6funcIssue Fixed:
Requirements:
Notes: