This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: enable CSI addons on upgrade when appropriate #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2347 +/- ##
==========================================
+ Coverage 71.9% 71.91% +0.01%
==========================================
Files 130 130
Lines 23395 23404 +9
==========================================
+ Hits 16823 16832 +9
Misses 5546 5546
Partials 1026 1026 |
jackfrancis
reviewed
Nov 23, 2019
| o.KubernetesConfig.Addons[i] = defaultCloudNodeManagerAddonsConfig | ||
| // Ensure cloud-node-manager and CSI components are enabled on appropriate upgrades | ||
| if isUpgrade && to.Bool(o.KubernetesConfig.UseCloudControllerManager) && | ||
| common.IsKubernetesVersionGe(o.OrchestratorVersion, "1.16.0") { |
There was a problem hiding this comment.
Let's add a UT that validates that a 1.15-->1.16 upgrade w/ all three of these addons disabled initially is statically overwritten to enabled=true (which is what I interpret this back-compat logic to be doing)
|
/hold Pending additional unit tests. |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mboersma
added a commit
that referenced
this pull request
Nov 26, 2019
* fix: enable CSI addons on upgrade when appropriate * test: add coverage for 1.16 upgrade w/ UseCloudControllerManager
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Follows up on #2345 to fix the enabling csi-azuredisk-* and csi-azurefile-* components on upgrade. Also addresses a review comment on the previous PR.
Issue Fixed:
Refs #2337
Requirements:
Notes: