This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: correct defaults order for setting IPAddressCount #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually confirmed that had the UT added in this PR been in place prior to #2274 this bug would not have landed. Tears. |
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #2358 +/- ##
==========================================
+ Coverage 71.9% 71.91% +<.01%
==========================================
Files 130 130
Lines 23395 23397 +2
==========================================
+ Hits 16823 16825 +2
Misses 5546 5546
Partials 1026 1026 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This fixes a regression that landed w/ #2274
The functional bug is this:
If you are using Azure CNI, and you are specifying a custom
IPAddressCountfor either master vm nodes or any node pool vms, those user-provided values will be overwritten by the aks-engine defaults.The IPAddressCount values in MasterProfile and each AgentPoolProfile depend (in part) upon the kublet configuration
--max-pods; essentially these values are related and need to be configured in concert according to a deterministic ordinality.This PR moves the IPAddressCount default enforcement for both masters and pools to occur after the kubelet defaults codeflow.
The primary fix here is missing UT. :(
Issue Fixed:
Requirements:
Notes: