This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
refactor: move addons consts to pkg/api/common #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2383 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 130 130
Lines 23344 23344
=======================================
Hits 16828 16828
Misses 5491 5491
Partials 1025 1025 |
CecileRobertMichon
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
force-pushed
the
addons-consts
branch
from
30e1fac
to
d4b1ca8
Compare
|
New changes are detected. LGTM label has been removed. |
CecileRobertMichon
removed
the
needs-rebase
devigned
pushed a commit
to devigned/aks-engine
that referenced
this pull request
Dec 9, 2019
|
Related to #2251 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Addon name consts are being used by both template generation (
pkg/engine) and cluster data model composition (pkg/api). This PR moves all addon consts topkg/api/commonso that we no longer have duplicate const definitions of the same values for local usage inpkg/engineandpkg/api, respectively.Issue Fixed:
Requirements:
Notes: