This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: Adding a unique id to Windows VHDs for telemtry correlation #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2388 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 130 130
Lines 23310 23310
=======================================
Hits 16803 16803
Misses 5482 5482
Partials 1025 1025 |
PatrickLang
reviewed
Dec 3, 2019
| @@ -241,6 +241,7 @@ switch ($env:ProvisioningPhase) | |||
| Install-Docker | |||
| Get-ContainerImages | |||
| Get-FilesToCacheOnVHD | |||
| (New-Guid).Guid | Out-File -FilePath 'c:\vhd-id.txt' | |||
There was a problem hiding this comment.
would putting this in a machine env var help with AppInsights integration?
There was a problem hiding this comment.
n/m, the CSE will be able to read this just fine
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding a unique ID file to Windows VHDs so we can correlate telemetry from Windows node setup extensions to a specific VHD image
Issue Fixed:
Requirements:
Notes: