feat: add linux CSE tracing and metrics #2415
Conversation
1a817e1
to
25798ab
Compare
25798ab
to
213f5fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2415 +/- ##
==========================================
+ Coverage 72.15% 72.22% +0.06%
==========================================
Files 130 130
Lines 24486 24504 +18
==========================================
+ Hits 17668 17698 +30
+ Misses 5797 5785 -12
Partials 1021 1021 |
this PR is much cleaner now :) |
21e1483
to
0671c60
Compare
37cb3cf
to
fd0cdbd
Compare
fd0cdbd
to
f8f9e79
Compare
5874ad3
to
5511590
Compare
b86fe3a
to
50c258a
Compare
/hold cancel |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR is only waiting on getting ampz v0.4.0 into the prod storage bucket. Right now, it points to the staging bucket. Once I update it to point at the prod bucket, I'll remove the WIP tag. @jchauncey, let me know if you need any additional info to approve the prod deploy jobs. |
@marosset, please give this another look when you have a sec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
else | ||
REBOOTREQUIRED=false | ||
fi | ||
|
||
{{- if not NeedsContainerd}} | ||
cleanUpContainerd | ||
time_metric "CleanupContainerd" cleanUpContainerd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palma21 FYI, AKS Engine CSE is now instrumented for App Insights telemetry. The time_metric
func above is a wrapper around all CSE step executions, which is disabled by default, and is a no-op.
Just FYI.
Reason for Change:
It would help development if we were able to have more insight into the behavior of aks-engine.
This PR introduces a new command line tool for sending telemetry to Application Insights, apmz (docs in progress).
apmz
outputs each trace and metric to an intermediate file, then flushes them at the end. This behavior is only activated when the feature is turned on in the API model. When the feature is not active, there are still stub no-op bash functions available.To query this data, you can run the following kql
Issue Fixed:
Fixes #2248
Requirements:
Notes: