Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add linux CSE tracing and metrics #2415

Merged
merged 1 commit into from Jan 15, 2020
Merged

Conversation

devigned
Copy link
Member

@devigned devigned commented Dec 9, 2019

Reason for Change:

It would help development if we were able to have more insight into the behavior of aks-engine.

This PR introduces a new command line tool for sending telemetry to Application Insights, apmz (docs in progress). apmz outputs each trace and metric to an intermediate file, then flushes them at the end. This behavior is only activated when the feature is turned on in the API model. When the feature is not active, there are still stub no-op bash functions available.

To query this data, you can run the following kql

customMetrics
| where customDimensions.os_type == "linux" and customDimensions.correlation_id == "41b61b03-ae2d-495d-a0f7-869afb024ed3"
| order by timestamp asc 

Issue Fixed:

Fixes #2248

Requirements:

Notes:

@marosset
Copy link
Contributor

marosset commented Dec 9, 2019

@devigned i opened a new PR with only the apimodel changes for enabling telemetry. Let's try and get that merged and we can work on enabling telemetry for linux and windows CSEs independently
#2417

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #2415 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
+ Coverage   72.15%   72.22%   +0.06%     
==========================================
  Files         130      130              
  Lines       24486    24504      +18     
==========================================
+ Hits        17668    17698      +30     
+ Misses       5797     5785      -12     
  Partials     1021     1021

@marosset
Copy link
Contributor

this PR is much cleaner now :)

@devigned devigned force-pushed the cse-tracing branch 3 times, most recently from 21e1483 to 0671c60 Compare December 14, 2019 16:32
@devigned devigned force-pushed the cse-tracing branch 2 times, most recently from 37cb3cf to fd0cdbd Compare December 16, 2019 05:15
@devigned devigned changed the title [WIP] feat: add linux CSE tracing and metrics feat: add linux CSE tracing and metrics Dec 16, 2019
@jackfrancis jackfrancis added this to Under Review in backlog Dec 18, 2019
@jackfrancis jackfrancis moved this from Under Review to In progress in backlog Dec 18, 2019
@devigned devigned force-pushed the cse-tracing branch 2 times, most recently from 5874ad3 to 5511590 Compare January 13, 2020 16:59
@devigned devigned changed the title feat: add linux CSE tracing and metrics [WIP] feat: add linux CSE tracing and metrics Jan 13, 2020
@devigned devigned force-pushed the cse-tracing branch 2 times, most recently from b86fe3a to 50c258a Compare January 14, 2020 01:20
@devigned
Copy link
Member Author

/hold cancel

@devigned
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@devigned
Copy link
Member Author

This PR is only waiting on getting ampz v0.4.0 into the prod storage bucket. Right now, it points to the staging bucket. Once I update it to point at the prod bucket, I'll remove the WIP tag.

@jchauncey, let me know if you need any additional info to approve the prod deploy jobs.

@devigned devigned changed the title [WIP] feat: add linux CSE tracing and metrics feat: add linux CSE tracing and metrics Jan 14, 2020
@devigned
Copy link
Member Author

@marosset, please give this another look when you have a sec.

Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

backlog automation moved this from In progress to Under Review Jan 15, 2020
@acs-bot acs-bot added the lgtm label Jan 15, 2020
@acs-bot acs-bot merged commit bcad1bd into Azure:master Jan 15, 2020
backlog automation moved this from Under Review to Done Jan 15, 2020
@acs-bot
Copy link

acs-bot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

else
REBOOTREQUIRED=false
fi

{{- if not NeedsContainerd}}
cleanUpContainerd
time_metric "CleanupContainerd" cleanUpContainerd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palma21 FYI, AKS Engine CSE is now instrumented for App Insights telemetry. The time_metric func above is a wrapper around all CSE step executions, which is disabled by default, and is a no-op.

Just FYI.

@devigned devigned deleted the cse-tracing branch July 14, 2020 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

Instrument CSE scripts for Linux
5 participants