Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: Rotate app insights key #2423

Merged
merged 1 commit into from Dec 10, 2019
Merged

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Dec 10, 2019

Reason for Change:

The resource group containing the application insights instance with the old telmetry key was accidentally deleted from our test sub

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #2423 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2423   +/-   ##
=======================================
  Coverage   72.03%   72.03%           
=======================================
  Files         130      130           
  Lines       23386    23386           
=======================================
  Hits        16846    16846           
  Misses       5516     5516           
  Partials     1024     1024

@devigned
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Dec 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset marosset closed this Dec 10, 2019
@marosset marosset deleted the rotate-app-insight-key branch December 10, 2019 20:40
@marosset marosset restored the rotate-app-insight-key branch December 10, 2019 20:41
@marosset marosset reopened this Dec 10, 2019
@marosset marosset merged commit c4e58ce into Azure:master Dec 10, 2019
@marosset marosset deleted the rotate-app-insight-key branch December 10, 2019 20:41
@jackfrancis jackfrancis added this to the v0.45.0 milestone Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants