This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
refactor: make kube-proxy addon user-configurable #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
jackfrancis
force-pushed
the
addons-kube-proxy
branch
from
2aa5f5e
to
faa1860
Compare
Codecov Report
@@ Coverage Diff @@
## master #2426 +/- ##
=========================================
+ Coverage 72.29% 72.3% +<.01%
=========================================
Files 130 130
Lines 23606 23648 +42
=========================================
+ Hits 17066 17098 +32
- Misses 5516 5524 +8
- Partials 1024 1026 +2 |
jackfrancis
commented
Dec 12, 2019
| @@ -7590,22 +8132,37 @@ func TestSetAddonsConfig(t *testing.T) { | |||
| Containers: []KubernetesContainerSpec{ | |||
| { | |||
| Name: "kubedns", | |||
| Image: specConfig.KubernetesImageBase + K8sComponentsByVersionMap["1.15.4"][common.KubeDNSAddonName], | |||
There was a problem hiding this comment.
Cleaning this errata up while I'm here
jackfrancis
commented
Dec 12, 2019
| }, | ||
| { | ||
| Name: "dnsmasq", | ||
| Image: specConfig.KubernetesImageBase + K8sComponentsByVersionMap["1.15.4"]["dnsmasq"], |
jackfrancis
commented
Dec 12, 2019
| }, | ||
| { | ||
| Name: "sidecar", | ||
| Image: specConfig.KubernetesImageBase + K8sComponentsByVersionMap["1.15.4"]["k8s-dns-sidecar"], | ||
| Image: specConfig.KubernetesImageBase + K8sComponentsByVersionMap["1.13.11"]["k8s-dns-sidecar"], |
jackfrancis
force-pushed
the
addons-kube-proxy
branch
from
ea5c39f
to
5f7c30b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Related to #2251 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR makes the
kube-proxycomponent a user-configurable addon, exposed via the existingkubernetesConfig.addonsinterface.Issue Fixed:
Requirements:
Notes: