Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update azure-npm-daemonset addon to v1.0.30 #2472

Merged
merged 2 commits into from Dec 18, 2019

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Updates to the latest release of Azure NPM:

  • removing telemetry sidecar from NPM
  • set NPM resource limits

Derived from #2443, implementing on top of recent master due to lots of moving parts in the addons space at present.

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/L label Dec 17, 2019
@jackfrancis
Copy link
Member Author

@jaer-tsun I think this is what we want. Specifically:

  • we need to update all the azure npm specs:
    1. the spec for all versions of k8s < 1.16
    2. the spec for k8s 1.16
    3. the spec for k8s 1.17
  • we need to entirely remove the reference to the telemetry container everywhere
  • we need to maintain back-compat with earlier specs (incl. the existence of the telemetry container)

UT have been updated accordingly.

@acs-bot
Copy link

acs-bot commented Dec 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member Author

FYI keeping the older versions of NPM + the telemetry container in the VHD in the event that AKS continues to use those older versions while continuing to pick up new VHDs.

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #2472 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2472      +/-   ##
==========================================
- Coverage   72.57%   72.56%   -0.02%     
==========================================
  Files         130      130              
  Lines       23916    23906      -10     
==========================================
- Hits        17358    17348      -10     
  Misses       5530     5530              
  Partials     1028     1028

@jackfrancis
Copy link
Member Author

Validated the new Azure NPM spec w/ 1.30 against k8s 1.15, 1.16, and 1.17

@jackfrancis jackfrancis merged commit 5dc9c4e into Azure:master Dec 18, 2019
@jackfrancis jackfrancis deleted the azure-npm-v1.0.30 branch December 18, 2019 01:05
@mboersma mboersma added this to the v0.46.0 milestone Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants