-
Notifications
You must be signed in to change notification settings - Fork 526
perf: upgrade AKS tunnel image in VHD #2546
Conversation
pullContainerImage "docker" ${CONTAINER_IMAGE} | ||
echo " - ${CONTAINER_IMAGE}" >> ${VHD_LOGS_FILEPATH} | ||
done | ||
|
||
KUBE_SVC_REDIRECT_VERSIONS="1.0.2" | ||
KUBE_SVC_REDIRECT_VERSIONS="1.0.5 1.0.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also have 1.0.4 in mcr, do we not need that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also are these images the same as that in acr? Depends on when we completely move to mcr, some cluster may still need to use acr image by the time this vhd is rolled out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to our toggle, 1.0.4 is not used anymore.
mcr has all images including the old images, those are copied from acr. so there won't be a problem when switching to mcr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gossion, jackfrancis, xuto2, yangl900 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
The AKS tunnel images in VHD are out-of-date, we need to bake new images in the VHD
Issue Fixed:
Requirements:
Notes: