Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

perf: upgrade AKS tunnel image in VHD #2546

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

gossion
Copy link
Member

@gossion gossion commented Jan 9, 2020

Reason for Change:

The AKS tunnel images in VHD are out-of-date, we need to bake new images in the VHD

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/XS label Jan 9, 2020
pullContainerImage "docker" ${CONTAINER_IMAGE}
echo " - ${CONTAINER_IMAGE}" >> ${VHD_LOGS_FILEPATH}
done

KUBE_SVC_REDIRECT_VERSIONS="1.0.2"
KUBE_SVC_REDIRECT_VERSIONS="1.0.5 1.0.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have 1.0.4 in mcr, do we not need that?

Copy link
Contributor

@xuto2 xuto2 Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also are these images the same as that in acr? Depends on when we completely move to mcr, some cluster may still need to use acr image by the time this vhd is rolled out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our toggle, 1.0.4 is not used anymore.
mcr has all images including the old images, those are copied from acr. so there won't be a problem when switching to mcr.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jan 9, 2020
@jackfrancis jackfrancis merged commit f9dd0e8 into Azure:master Jan 9, 2020
@acs-bot
Copy link

acs-bot commented Jan 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gossion, jackfrancis, xuto2, yangl900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants