Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: update addon-resizer to v1.8.4 #256

Merged
merged 1 commit into from Jan 9, 2019

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Jan 9, 2019

Reason for Change:

Rev our addon-resizer v1.8 dependencies to the latest patch release.

Issue Fixed:

Requirements:

Notes:

@mboersma
Copy link
Member

mboersma commented Jan 9, 2019

Currently recommended version is 1.8, on addon-resizer-release-1.8 branch.

I guess that's all the compatibility guidance we have, so 👍.

@mboersma
Copy link
Member

mboersma commented Jan 9, 2019

/lgtm

Looks like this PR is waiting for codecov, which isn't working currently.

@acs-bot
Copy link

acs-bot commented Jan 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CecileRobertMichon
Copy link
Contributor

/label needs-rebase

codecov will work after rebase

@CecileRobertMichon CecileRobertMichon added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Jan 9, 2019
@jackfrancis jackfrancis merged commit 10ae038 into Azure:master Jan 9, 2019
@jackfrancis jackfrancis deleted the addon-resizer-1.8.4 branch January 9, 2019 23:59
@jackfrancis jackfrancis added this to Done in backlog Jan 11, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved lgtm needs-rebase Changes in the target branch require a `git rebase` and `git push -f` size/S
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants