This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: Set the default Windows sku and version when upgrading a VMSS #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
==========================================
+ Coverage 72.15% 72.16% +0.01%
==========================================
Files 130 130
Lines 24486 24497 +11
==========================================
+ Hits 17668 17679 +11
Misses 5797 5797
Partials 1021 1021 |
|
/approve |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AbelHu, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andyliuliming
pushed a commit
to andyliuliming/aks-engine
that referenced
this pull request
Jan 17, 2020
4 tasks
AbelHu
added a commit
to AbelHu/aks-engine
that referenced
this pull request
Jan 17, 2020
andyliuliming
pushed a commit
that referenced
this pull request
Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR sets default WindowsSku and WindowsVersion when upgrading a VMSS.
Issue Fixed:
Requirements:
Notes: