Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.16.6 #2588

Merged
merged 3 commits into from Jan 23, 2020
Merged

feat: add support for Kubernetes 1.16.6 #2588

merged 3 commits into from Jan 23, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jan 16, 2020 •
edited

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.16.md#changelog-since-v1164
and https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.16.md#changelog-since-v1165

Issue Fixed:

Requirements:

  • Windows artifacts uploaded to acsmirror blob store
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited

Codecov Report

Merging #2588 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2588   +/-   ##
=======================================
  Coverage   71.79%   71.79%           
=======================================
  Files         131      131           
  Lines       24787    24787           
=======================================
  Hits        17795    17795           
  Misses       5966     5966           
  Partials     1026     1026

@mboersma
Copy link
Member Author

Apprently the 1.16.5 hyperkube was also tagged as "1.16.6-beta.0", and that later tag won in the build:

Expected
    <string>: v1.16.5
to equal
    <string>: v1.16.6-beta.0


$ ORCHESTRATOR_RELEASE=1.16 akse-deploy 
$ k get no
NAME                                 STATUS   ROLES    AGE   VERSION
k8s-agentpool1-26399701-vmss000000   Ready    agent    53s   v1.16.6-beta.0
k8s-agentpool1-26399701-vmss000001   Ready    agent    59s   v1.16.6-beta.0
k8s-master-26399701-0                Ready    master   59s   v1.16.6-beta.0

That's very sad. I really don't want to hack up a test to work around this build error, nor do I want to wait for 1.16.6 in hopes that it will fix it.

@mboersma
Copy link
Member Author

/hold

See https://groups.google.com/forum/?nomobile=true#!topic/kubernetes-dev/Q0zNysVxTVE for a summary of current discussion on the git version problem that is blocking this PR. I think there will be a v1.16.6 soon that fixes this issue, so let's update this PR to that release when that happens.

@mboersma mboersma changed the title feat: add support for Kubernetes 1.16.5 feat: add support for Kubernetes 1.16.6 Jan 21, 2020
@mboersma
Copy link
Member Author

/hold cancel

jackfrancis
jackfrancis reviewed Jan 22, 2020
View reviewed changes
vhd/packer/install-dependencies.sh
@@ -424,6 +424,7 @@ echo " - busybox" >> ${VHD_LOGS_FILEPATH}
K8S_VERSIONS="
1.17.2
1.17.1
1.16.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the 1.16.1 versions from the VHD spec

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed 1.16.2 as well, since it's been disabled forever.

jackfrancis
jackfrancis reviewed Jan 22, 2020
View reviewed changes
vhd/packer/configure-windows-vhd.ps1
@@ -81,6 +81,7 @@ function Get-FilesToCacheOnVHD
"https://acs-mirror.azureedge.net/wink8s/v1.16.1-1int.zip",
"https://acs-mirror.azureedge.net/wink8s/v1.16.2-1int.zip",
"https://acs-mirror.azureedge.net/wink8s/v1.16.4-1int.zip",
"https://acs-mirror.azureedge.net/wink8s/v1.16.6-1int.zip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marosset Do we want to keep all these Windows versions pre-downloaded into the VHD, even those that aren't supported in the supported list above?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we usually just have supported versions here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't hurt anything tho, we have plenty of space on the VHD currently.

@acs-bot acs-bot added size/S and removed size/XS labels Jan 22, 2020
jackfrancis
jackfrancis previously approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jan 22, 2020
@acs-bot acs-bot removed the lgtm label Jan 22, 2020
jackfrancis
jackfrancis approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jan 22, 2020
marosset
marosset reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, marosset, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,marosset,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit 1a39e35 into Azure:master Jan 23, 2020
@mboersma mboersma deleted the add-k8s-1.16.5 branch January 24, 2020 14:20
@fmotrifork fmotrifork mentioned this pull request Feb 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marosset marosset marosset left review comments

@jackfrancis jackfrancis jackfrancis approved these changes

Assignees

@jackfrancis jackfrancis

@marosset marosset

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mboersma @acs-bot @jackfrancis @marosset