Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: update img binary to v0.5.6 #259

Merged
merged 1 commit into from Jan 10, 2019
Merged

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Jan 9, 2019

Reason for Change:

Use the latest published version of img for the binary we put on the node vms.

Issue Fixed:

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

to @mboersma for updating acs-mirror binaries

Here's the canonical source:

https://github.com/genuinetools/img/releases/tag/v0.5.6

@mboersma
Copy link
Member

mboersma commented Jan 9, 2019

/lgtm

@acs-bot acs-bot added the lgtm label Jan 9, 2019
@CecileRobertMichon
Copy link
Contributor

we should run a non-docker container runtime cluster e2e test for this as it's the only path using img (non of our current e2e tests cover that I believe).

/hold

@CecileRobertMichon
Copy link
Contributor

codecov will work after rebase

/label needs-rebase

@CecileRobertMichon CecileRobertMichon added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Jan 9, 2019
@CecileRobertMichon
Copy link
Contributor

test with containerd passed
/lgtm
/hold cancel

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #259 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   53.21%   53.25%   +0.03%     
==========================================
  Files          95       95              
  Lines       14248    14246       -2     
==========================================
+ Hits         7582     7586       +4     
+ Misses       6001     5995       -6     
  Partials      665      665

@acs-bot
Copy link

acs-bot commented Jan 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit c593ace into Azure:master Jan 10, 2019
@jackfrancis jackfrancis added this to Done in backlog Jan 11, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved lgtm needs-rebase Changes in the target branch require a `git rebase` and `git push -f` size/XS
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants