Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: Fix e2e test failure #2594

Merged
merged 2 commits into from Jan 17, 2020
Merged

fix: Fix e2e test failure #2594

merged 2 commits into from Jan 17, 2020

Conversation

chewong
Copy link

@chewong chewong commented Jan 16, 2020

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@chewong chewong changed the title bug: Fix e2e test failure fix: Fix e2e test failure Jan 16, 2020
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d470049). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2594   +/-   ##
=========================================
  Coverage          ?   72.17%           
=========================================
  Files             ?      130           
  Lines             ?    24604           
  Branches          ?        0           
=========================================
  Hits              ?    17759           
  Misses            ?     5820           
  Partials          ?     1025

@chewong chewong marked this pull request as ready for review January 17, 2020 00:28
jackfrancis
jackfrancis previously approved these changes Jan 17, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chewong
Copy link
Author

chewong commented Jan 17, 2020

Running 1.16 e2e tests (since it covers SGX) to verify this PR - https://upstream.jenkins.azure-containers.io/view/aks-engine%20PRs/job/k8s-create-cluster-matrix/67/

@acs-bot acs-bot added size/M and removed size/S labels Jan 17, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jan 17, 2020
@jackfrancis jackfrancis merged commit 623e9ae into Azure:master Jan 17, 2020
@acs-bot
Copy link

acs-bot commented Jan 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chewong chewong deleted the fix-e2e branch January 17, 2020 21:00
@chewong chewong restored the fix-e2e branch January 18, 2020 01:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants