Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: don't test for static node count if add node pool context #2619

Merged
merged 2 commits into from Jan 23, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

Until we make the E2E test runner more intelligent so that it is able to introspect the modified api model after a addpool operation, we should not check for a static node count in the E2E test job (because we are not correctly calculating the static count of nodes in the cluster in this context).

Issue Fixed:

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Jan 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #2619 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2619   +/-   ##
=======================================
  Coverage   71.79%   71.79%           
=======================================
  Files         131      131           
  Lines       24787    24787           
=======================================
  Hits        17795    17795           
  Misses       5966     5966           
  Partials     1026     1026

@acs-bot acs-bot added size/S and removed size/XS labels Jan 23, 2020
@jackfrancis jackfrancis merged commit 38fe8c4 into Azure:master Jan 23, 2020
@jackfrancis jackfrancis deleted the e2e-AddNodePoolInput branch January 23, 2020 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants