Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: upgrade control plane only #2635

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR adds a --control-plane-only option to the upgrade command, to enable upgrade operations to target only the master vms.

Issue Fixed:

Fixes #2134

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Jan 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis added this to In progress in backlog Jan 29, 2020
@stale
Copy link

stale bot commented Feb 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 28, 2020
@craiglpeters craiglpeters moved this from In progress to PriorityFuture in backlog Mar 4, 2020
@stale stale bot closed this Mar 6, 2020
backlog automation moved this from PriorityFuture to Done Mar 6, 2020
@jackfrancis jackfrancis reopened this Mar 6, 2020
backlog automation moved this from Done to Under Review Mar 6, 2020
@stale stale bot removed the stale label Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #2635 into master will increase coverage by 0.00%.
The diff coverage is 93.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2635   +/-   ##
=======================================
  Coverage   72.47%   72.48%           
=======================================
  Files         140      140           
  Lines       25683    25694   +11     
=======================================
+ Hits        18614    18624   +10     
- Misses       5993     5994    +1     
  Partials     1076     1076           
Impacted Files Coverage Δ
cmd/upgrade.go 47.09% <50.00%> (+0.03%) ⬆️
pkg/operations/kubernetesupgrade/upgradecluster.go 82.70% <100.00%> (+0.44%) ⬆️
pkg/operations/kubernetesupgrade/upgrader.go 61.06% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4140152...5897c25. Read the comment docs.

@jackfrancis jackfrancis changed the title [WIP] feat: upgrade control plane only feat: upgrade control plane only Mar 12, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit e2c8af3 into Azure:master Mar 12, 2020
backlog automation moved this from Under Review to Done Mar 12, 2020
@jackfrancis jackfrancis deleted the upgrade-control-plane-only branch March 12, 2020 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

Add option to upgrade control plane nodes only
4 participants