This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: enable MCR KubernetesImageBaseType #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
force-pushed
the
enable-mcr
branch
from
4aa160c
to
628fbcd
Compare
jackfrancis
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2722 +/- ##
==========================================
+ Coverage 72.34% 72.35% +0.01%
==========================================
Files 137 137
Lines 25327 25341 +14
==========================================
+ Hits 18322 18335 +13
- Misses 5948 5949 +1
Partials 1057 1057 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR introduces a "mcr" KubernetesImageBaseType, allowing AKS Engine to seamlessly cut over its dependency upon
k8s.gcr.ioto the official Kubernetes MCR registry @mcr.microsoft.com.Issue Fixed:
Requirements:
Notes: