feat: Windows containerd + azure-cni #2864
Conversation
|
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - |
ksubrmnn
force-pushed
the
containerd
branch
2 times, most recently
from
f6c561b
to
80f0ed3
Compare
Codecov Report
@@ Coverage Diff @@
## master #2864 +/- ##
==========================================
+ Coverage 72.57% 72.58% +<.01%
==========================================
Files 141 141
Lines 25889 25891 +2
==========================================
+ Hits 18790 18794 +4
+ Misses 6005 6003 -2
Partials 1094 1094 |
ksubrmnn
changed the title
| @@ -1677,9 +1677,6 @@ func (a *Properties) validateContainerRuntime() error { | |||
|
|
|||
| // TODO: These validations should be relaxed once ContainerD and CNI plugins are more readily available | |||
| if containerRuntime == Containerd && a.HasWindows() { | |||
There was a problem hiding this comment.
Should we add any validation around k8s version here?
Will containerd work with versions older than 1.18?
There was a problem hiding this comment.
I'm not sure. Who could I ask?
There was a problem hiding this comment.
I think we'll need to try it out 🤣
|
@ksubrmnn I think you need to remake the generated files after formatting the files with containerd functions |
Yep, realized that then got on a call mid make bootstrap. Should be fixed! |
|
/lgtm |
marosset
changed the title
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksubrmnn, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Once completed, this will install ContainerD and configure Kubernetes to use it on Windows with Azure CNI
Issue Fixed:
Requirements:
Notes:
/hold do-not-merge