Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: optimize apt_get_purge CSE func #2931

Merged
merged 1 commit into from Mar 23, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

  • make the retries, sleep timeout, and command timeout options static in the func (these options were common across all usages)
  • do the "is this package already installed?" validation before purging in the func itself
  • support multiple packages

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #2931 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2931   +/-   ##
=======================================
  Coverage   72.56%   72.56%           
=======================================
  Files         141      141           
  Lines       25863    25863           
=======================================
  Hits        18767    18767           
  Misses       6003     6003           
  Partials     1093     1093

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 1b05d71 into Azure:master Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants