Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: each apiserver process listens on its own IP address #2953

Merged
merged 3 commits into from Mar 30, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR sets the advertise address of the apiserver process to the local IP address, instead of the internal LB IP address of the cluster-wide apiserver.

Fixes #622
Fixes #2948

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #2953 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2953   +/-   ##
=======================================
  Coverage   72.57%   72.58%           
=======================================
  Files         141      141           
  Lines       25893    25893           
=======================================
+ Hits        18793    18794    +1     
+ Misses       6006     6005    -1     
  Partials     1094     1094           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 34.82% <ø> (ø)
cmd/root.go 59.89% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959247d...4fbb7d9. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants