This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: adding windows defender process exclusions #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2967 +/- ##
=======================================
Coverage 72.57% 72.57%
=======================================
Files 141 141
Lines 25934 25934
=======================================
Hits 18821 18821
Misses 6014 6014
Partials 1099 1099
Continue to review full report at Codecov.
|
mboersma
approved these changes
Mar 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Given current constraints in Azure, we may not get the 1.15 e2e to pass for a while, so I think we can consider this green enough to merge. 💚 |
|
Thanks Matt |
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
Apr 22, 2020
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
Apr 22, 2020
4 tasks
AbelHu
added a commit
to AbelHu/aks-engine
that referenced
this pull request
Apr 22, 2020
…d processes (Azure#2967) (Azure#3118) Co-authored-by: Mark Rossetti <marosset@microsoft.com>
4 tasks
xuto2
pushed a commit
that referenced
this pull request
Apr 23, 2020
* Upgrade Windows VHD image to April release (#3111) * chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790) * chore: update Azure CNI to v1.0.33 (#2825) * feat: collect Windows CSE logs during log collection (#2858) * fix: Windows no outbound fixes (#2883) * fix: fixing nssm logging in windows CSE (#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954) * feat: Updating AKS to use April 2020 Windows VHDs by default (#3060) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com> Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com> * feat: adding kubelet and csi-proxy-server as windows defender excluded processes (#2967) (#3118) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com> Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com>
AbelHu
pushed a commit
to AbelHu/aks-engine
that referenced
this pull request
Apr 23, 2020
andyliuliming
pushed a commit
that referenced
this pull request
Apr 23, 2020
* feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback * chore: adding azure-cni v1.0.33 artifacts to VHDs (#2790) * chore: update Azure CNI to v1.0.33 (#2825) * feat: collect Windows CSE logs during log collection (#2858) * fix: Windows no outbound fixes (#2883) * fix: fixing nssm logging in windows CSE (#2890) * fix: Get WindowsVersion from registry instead of calling Get-ComputerInfo (#2954) * feat: adding kubelet and csi-proxy-server as windows defender excluded processes (#2967) * feat: Updating AKS to use April 2020 Windows VHDs by default (#3060) * feat: Updating Windows VHDs with 4B patches (#3115) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Jaeryn <13284103+jaer-tsun@users.noreply.github.com> Co-authored-by: Kalya Subramanian <42158129+ksubrmnn@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Windows defender process exclusions for kubelet.exe and csi-proxy-server.exe to reduce unnecessary cpu load on Windows nodes
Reason for Change:
This is an ask from @mikkelhegn from AKS team
Issue Fixed:
Requirements:
Notes: