This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: switch dev image to go 1.13 version #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2976 +/- ##
=======================================
Coverage 72.58% 72.58%
=======================================
Files 141 141
Lines 25893 25893
=======================================
Hits 18794 18794
Misses 6005 6005
Partials 1094 1094 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We have seen
aks-engine.exebinaries released after v0.39.0 fail similarly to golang/go#37149. It appears that will be fixed in upcoming releases of the go toolchain, 1.13.10 and 1.14.2.For now, we verified that go 1.13 creates a Windows binary that doesn't crash. This change specifies go 1.13 in documentation and uses a go-dev release that differs from our current toolbox only by reverting the compiler to 1.13.
Issue Fixed:
Requirements:
Notes:
We should pounce on go 1.13.10 when it is released, because there have been numerous other toolchain fixes that we are ignoring here in favor of not having the binary crash. ⚖️