feat: add support for Kubernetes 1.19.0-alpha.1 #2982
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2982 +/- ##
==========================================
- Coverage 72.58% 72.06% -0.52%
==========================================
Files 141 141
Lines 25893 26186 +293
==========================================
+ Hits 18794 18871 +77
- Misses 6005 6221 +216
Partials 1094 1094
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.19 surface area looks good. Let's omit the additional 1.19 pipeline job before merging, after getting functional signal on this PR.
d5526fb
to
6ec6484
Compare
Had a passing run with 1.19 on the second try, and it has passed e2e for me locally. So I'll discard the 1.19 e2e testing commit now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#v1190-alpha1
Issue Fixed:
Requirements:
Notes:
I added 1.19 to the PR mix, but we can drop that commit if need be to keep our cloud footprint minimal.