Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.19.0-alpha.1 #2982

Merged
merged 1 commit into from Mar 30, 2020

Conversation

mboersma
Copy link
Member

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#v1190-alpha1

Issue Fixed:

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:
I added 1.19 to the PR mix, but we can drop that commit if need be to keep our cloud footprint minimal.

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #2982 into master will decrease coverage by 0.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2982      +/-   ##
==========================================
- Coverage   72.58%   72.06%   -0.52%     
==========================================
  Files         141      141              
  Lines       25893    26186     +293     
==========================================
+ Hits        18794    18871      +77     
- Misses       6005     6221     +216     
  Partials     1094     1094              
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.55% <ø> (ø)
pkg/engine/templates_generated.go 31.69% <ø> (-3.13%) ⬇️
pkg/api/k8s_versions.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12cca7f...6ec6484. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.19 surface area looks good. Let's omit the additional 1.19 pipeline job before merging, after getting functional signal on this PR.

@mboersma
Copy link
Member Author

mboersma commented Mar 30, 2020

Had a passing run with 1.19 on the second try, and it has passed e2e for me locally. So I'll discard the 1.19 e2e testing commit now.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Mar 30, 2020
@jackfrancis jackfrancis merged commit 6381d64 into Azure:master Mar 30, 2020
@mboersma mboersma deleted the add-k8s-1.19.0-alpha.1 branch March 30, 2020 17:30
@acs-bot
Copy link

acs-bot commented Mar 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants