Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: etcd metrics URL #2989

Merged
merged 2 commits into from Mar 31, 2020
Merged

feat: etcd metrics URL #2989

merged 2 commits into from Mar 31, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Mar 30, 2020

Reason for Change:

This PR adds the --listen-metrics-urls option to the etcd runtime configuration for prometheus metrics scraping.

Issue Fixed:

Fixes #2171

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #2989 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2989   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         141      141           
  Lines       26184    26190    +6     
=======================================
+ Hits        18871    18877    +6     
  Misses       6219     6219           
  Partials     1094     1094           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 31.69% <ø> (ø)
pkg/engine/armvariables.go 87.44% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8453a6a...ef63f11. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants