Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: UT for addons ip-masq-agent image override #2997

Merged
merged 1 commit into from Mar 31, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR adds a unit test to prove that when you upgrade to 1.16, your custom ip-masq-agent addon image value will be overridden to use the aks-engine default.

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Mar 31, 2020
@acs-bot
Copy link

acs-bot commented Mar 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #2997 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2997   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files         141      141           
  Lines       26257    26257           
=======================================
  Hits        18937    18937           
  Misses       6227     6227           
  Partials     1093     1093           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a850a...73a42ab. Read the comment docs.

@jackfrancis jackfrancis merged commit 20854f3 into Azure:master Mar 31, 2020
@jackfrancis jackfrancis deleted the ip-masq-agent-upgrade branch March 31, 2020 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants